Skip to content

Commit

Permalink
Merge pull request #159 from dotindustries/fix/remove-history-generic
Browse files Browse the repository at this point in the history
fix: remove history generic
  • Loading branch information
nadilas authored Mar 23, 2024
2 parents 96d0cf6 + 9ec9101 commit 5e21d78
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,12 @@ keep the history around for a bit longer. The library uses json-patch RFC6902 fo
- Diff
- Status
- Apply
> ⚠️ Setting a value for an undefined prop `{prop: undefined}` will result in the `compare` call as a `replace`
operation, but will be recorded by the observer as
an `add` operation. See https://github.com/Starcounter-Jack/JSON-Patch/issues/280 for details
> ⚠️ Currently with a workaround to adapt for setting a value for an undefined prop `{prop: undefined}` will result in
the `compare` call as a `replace`
operation, but will be recorded by the observer as an `add` operation.
> Applying a patch like that will result in internal retry with `add` instead of `replace`.
>
> See https://github.com/Starcounter-Jack/JSON-Patch/issues/280 for details
- Visualization via `@dotinc/ogre-react`
- Merge
- fast-forward
Expand Down
2 changes: 1 addition & 1 deletion packages/ogre/src/git2json.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const findRefs = (commit: Commit, refs: Map<string, Reference>) => {
* in the Repository history. The json representation is returned in `git2json` format based on:
* https://github.com/fabien0102/git2json/blob/e067166d2468018b6f3982a8fb44a2e54110ce02/src/git2json.js#L5-L22
*/
export const formatGit2Json = <T = any>(history: History<T>) => {
export const formatGit2Json = <T = any>(history: History) => {
const { commits, refs } = history;
return commits.reverse().map((c) => {
const [name, email] = cleanAuthor(c.author);
Expand Down

0 comments on commit 5e21d78

Please sign in to comment.