Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!166] Improve publish app #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −3
Open

[!166] Improve publish app #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ All notable changes to the `python-domino` library will be documented in this fi

### Changed

## 1.4.3

### Added

Support environmentId and externalVolumeMountIds in app_publish

## 1.4.2

### Added
Expand Down
2 changes: 1 addition & 1 deletion domino/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "1.4.2"
__version__ = "1.4.3"
8 changes: 6 additions & 2 deletions domino/domino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,15 +889,19 @@ def collaborators_remove(self, username_or_email):
return response

# App functions
def app_publish(self, unpublishRunningApps=True, hardwareTierId=None):
def app_publish(self, unpublishRunningApps=True, hardwareTierId=None, environmentId=None, externalVolumeMountIds=None):
if unpublishRunningApps:
self.app_unpublish()
app_id = self._app_id
if app_id is None:
# No App Exists creating one
app_id = self.__app_create(hardware_tier_id=hardwareTierId)
url = self._routes.app_start(app_id)
request = {"hardwareTierId": hardwareTierId}
request = {
"hardwareTierId": hardwareTierId,
"environmentId": environmentId,
"externalVolumeMountIds": externalVolumeMountIds
}
response = self.request_manager.post(url, json=request)
return response

Expand Down