Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!166] Improve publish app #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FouadApp
Copy link

@FouadApp FouadApp commented Oct 2, 2024

What issue does this pull request solve?

The issue encountered is the inability to add essential parameters such as environmentId and externalVolumeMountIds in the method responsible for executing app_publish

What is the solution?

Add environmentId and externalVolumeMountIds

‘''
if unpublishRunningApps:
self.app_unpublish()
app_id = self._app_id
if app_id is None:
# No App Exists creating one
app_id = self.__app_create(hardware_tier_id=hardwareTierId)
url = self._routes.app_start(app_id)
request = {
"hardwareTierId": hardwareTierId,
"environmentId": environmentId,
"externalVolumeMountIds": externalVolumeMountIds
}
response = self.request_manager.post(url, json=request)
return response
‘‘‘

Testing

  • Unit test(s)

Pull Request Reminders

References (optional)

@FouadApp FouadApp requested a review from a team as a code owner October 2, 2024 19:24
@ddl-mmahmoud
Copy link
Contributor

ddl-mmahmoud commented Oct 9, 2024

Hi @FouadApp, we are currently qualifying a Domino Standard Environment release candidate. After it is finalized we will accept this PR for the next release candidate! (It is likely a version bump will be required before merge.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants