Add ClimateEntityFeature.TURN_OFF feature & implementation
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxr
changed the title
ClimateEntityFeature.TURN_OFF and ClimateEntityFeature.TURN_OFF feature flagsClimateEntityFeature.TURN_OFF and ClimateEntityFeature.TURN_ON feature flags
mxr
changed the title
ClimateEntityFeature.TURN_OFF and ClimateEntityFeature.TURN_ON feature flagsClimateEntityFeature.TURN_OFF and ClimateEntityFeature.TURN_ON features
mxr
changed the title
ClimateEntityFeature.TURN_OFF and ClimateEntityFeature.TURN_ON featuresClimateEntityFeature.TURN_OFF and ClimateEntityFeature.TURN_ON features & implementation
dlarrick
reviewed
Dec 14, 2024
mxr
changed the title
ClimateEntityFeature.TURN_OFF and ClimateEntityFeature.TURN_ON features & implementationClimateEntityFeature.TURN_OFF feature & implementation
|
Limiting the scope here for compatibility with 2025.1 seems like a good idea. Thanks. Given how much back & forth there's been on this one I want to try it first in my own system before merging, but right now this looks good. I hope to find time this weekend to catch up on a few things with the integration. I'd also accept a separate PR that adds |
|
Sounds good. It worked on my system so hopefully it works in yours as well. |
dlarrick
approved these changes
Dec 15, 2024
|
Addresses part of #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of #163 which implements the
turn_offaction and updates documentation.