-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClimateEntityFeature.TURN_OFF for Google Assistant calls #163
Conversation
Google Assistant expects to call the turn_off service which does not exist unless specifically enabled as a ClimateEntityFeature.TURN_OFF feature. Previously calls to turn off my Kumo devices would fail silently from Google and an error message in Home Assistant regarding an unsupported service. I have tested this change to fix my issue.
Discussion in #137 |
@dlarrick any thoughts on this one? Seems to work great for my setup. (Both via Google Assistant and Home Assistant apps) |
Didn't we remove this to stop some deprecation warning? Let me dig up that PR too... |
I am starting to think this PR is, in fact, exactly what's needed for Google Assistant: I was trying to understand how it could do Climate.TURN_ON without remembering what mode it was in last, but this PR avoids that issue. I'm hoping to have some time to test over the next few weeks; but in the meantime if folks who have noted this issue could try out this PR, that would be helpful. @OmenWild @VeniceNerd @ilndboy |
I can confirm I was experiencing this issue (with Alexa or even when triggering |
Thinking on this more, to support 2025.1, I think you actually need to implement I have done so in #176 |
I think that's incorrect. I think we can choose to implement If I'm wrong here we'll have to do something else, like store the last HVAC mode in a file for use in |
#176 addressing the same issue is now merged. |
Google Assistant expects to call the turn_off service which does not exist unless specifically enabled as a ClimateEntityFeature.TURN_OFF feature.
Previously calls to turn off my Kumo devices would fail silently from Google and an error message in Home Assistant regarding an unsupported service.
I have tested this change to fix my issue.