-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Universal snippet for django CMS 3 and 4 #160
Conversation
…nment variable (#89)
…ning is enabled (#98)
* init support for django4.2 * add change log for add compatiable for django 4.2 and python 3.10 * Update CHANGELOG.rst * Update .pre-commit-config.yaml * fix lint config issue * remove test code * add blackline for flake8 * add pyproject.toml file * add requirement files * fix ci failed issue * format setup.py import section * upgrade isort version to fix pre commit ci issue * upgrade the django-upgrade package to pass through the pre commit ci test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * upgrade packages in pre commit * resort init file changes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * comment the django-upgrade from ci * fix: add missing migration file * fix: update previous file instead of creating new file --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Josh Peng Yu <[email protected]>
* Added site field in models n site filter in admin * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated versioning branch * Add test cases and updated the implementation * Update CHANGELOG.rst Co-authored-by: Mark Walker <[email protected]> * corrected formatting * fixed flake8 issues * removed list_filter --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mark Walker <[email protected]>
* bump version to 4.1.0 * bump version to 4.1.0 pyproject.toml * replace test requirement url * update changelog date * update release date.
for more information, see https://pre-commit.ci
…pet into feat/universal
@joshyu Can you have a look at this? It should also work with django CMS 4.0. I'd appreciate if you found time to test. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@fsbraun, |
@fsbraun , |
@joshyu Interesting since |
* fix: manifest.in * fix: SnippetAdmin use overrdden change_form_template * ci: auto fixes from pre-commit hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@fsbraun , I think you also need to include |
35a82be
to
d86e6c4
Compare
@joshyu Fixed. |
Description
This PR updates django CMS snippet to become universal, i.e. support django CMS 3.11, 4.0, and 4.1.
All features from the
support/django-cms-4.0.x
branch are included.SnippetGrouper
model is introduced. This has no impact on end-usersThis will be the base for version 5 of djangocms-snippet:
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.