Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge 4.0.1.x branch to master: make snippet component versioning #166

Open
joshyu opened this issue Aug 19, 2024 · 3 comments
Open

merge 4.0.1.x branch to master: make snippet component versioning #166

joshyu opened this issue Aug 19, 2024 · 3 comments

Comments

@joshyu
Copy link
Contributor

joshyu commented Aug 19, 2024

Hi team,

Recently we are about to upgrade our CMS version to 4.1.2, but we still need the feature of making snippet versioning. Currently all of the versioning related changes are in the branch support/django-cms-4.0.x. Is it possible to merge this branch to master? we can cherry-pick and merge every meaningful changes.

@fsbraun , @Aiky30 ,
please provide your input.

@fsbraun
Copy link
Member

fsbraun commented Aug 19, 2024

@joshyu what's your opinion on #160? Snippets for everyone?

@joshyu
Copy link
Contributor Author

joshyu commented Aug 19, 2024

@fsbraun,
Cool. I missed this PR. it's just what we want.
I will give it a test and give you my feedback.

@joshyu
Copy link
Contributor Author

joshyu commented Aug 19, 2024

Hi @fsbraun ,

I installed this PR branch to djangocms-quickstart for a test, but failed to build web image.
image

I found that the template folder and internal files are missing from the directory tree.
image

Can you please check it?

@joshyu joshyu mentioned this issue Aug 20, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants