go.mod: restore Go 1.22 support #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's some crypto changes that need to be changed for this to pass. See the failing tests. |
|
https://github.com/diskfs/go-diskfs/actions/runs/11157473532/job/31122367815?pr=262 |
Go 1.22 has not reached its EOL yet. `math/rand/v2.(*Chacha8).Read` is replaced with `crypto/rand.Read`, as the former one is not available in Go 1.22. Signed-off-by: Akihiro Suda <[email protected]>
|
Yeah. See my comment on the other issue. Just switch it back to crypto/rand in this PR and it should be clean. |
deitch
approved these changes
Oct 7, 2024
|
All looks good. You ready for merge @AkihiroSuda ? |
Yes, thanks |
|
Thanks for driving this @AkihiroSuda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.22 has not reached its EOL yet