fix offset when reading and writing fat32 files to avoid overruns #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
force-pushed
the
fat32-file-offset-int64
branch
from
f8062fe to
b06291e
Compare
Signed-off-by: Avi Deitcher <[email protected]>
deitch
force-pushed
the
fat32-file-offset-int64
branch
from
b06291e to
24489a6
Compare
AkihiroSuda
reviewed
Oct 7, 2024
| @@ -258,7 +264,7 @@ func TestFat32Read(t *testing.T) { | |||
| corrupted := "" | |||
| if tt.bytechange >= 0 { | |||
| b := make([]byte, 1) | |||
| _, _ = rand.Read(b) | |||
| _, _ = chacha.Read(b) | |||
There was a problem hiding this comment.
Any reason to switch away from crypto/rand to math/rand/v2 ?
https://pkg.go.dev/math/rand/v2#ChaCha8.Read is not available for Go 1.22
There was a problem hiding this comment.
Nope. It was done because lint was complaining when go1.23. With 1.22 we should not switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue raised by @mrbojangles3.
With thanks to @mrbojangles3, whose tests are now incorporated into
fat32_test.go