-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement remove and rename feature for fat32 #233
Merged
deitch
merged 8 commits into
diskfs:master
from
ludelion5:feat/remove-and-rename-for-fat32
Nov 17, 2024
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8027e3a
feat: implement remove and rename feature for fat32, add new unit-tests
ludelion5 94dc70c
Merge remote-tracking branch 'origin/master' into feat/remove-and-ren…
ludelion5 afb9826
task: transform RemoveFile() method into Remove() for interface compa…
ludelion5 96aacec
task: transform RenameFile() method into Rename() for interface compa…
ludelion5 a604405
task: support renaming of directories (in same dir)
ludelion5 737ccd7
remove nolint comment
ludelion5 a3bfd1e
fix: linter findings
ludelion5 9e1a13c
fix: linter findings
ludelion5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the method got implemented, lint exception is not needed anymore here. Please remove it.