implement remove and rename feature for fat32

[ludelion5]

Sorry for the late PR. Here is my proposal to rename and remove files in fat32.

closes #191

[deitch]

Overall, this looks great, and thank you.

In terms of naming, are these meant to be restricted just to files, or any structure (files, dirs, symlinks where supported, etc.)? I would think the latter, since CLI-level commands for the above in most OSes don't care. Same for linux mv / Windows ren.

So should these be RemoveFile() and RenameFile(), or just Remove() and Rename()?

On the other hand, in keeping with golang style, maybe these should parallel and be Remove() and RemoveAll() and [Rename()](https://pkg.go.dev/os#Rename]?

[ludelion5]

Thanks for the feedback. I will look into your request and test, if the implementation will also work for symlinks and directories. If so, its a good idea to stick to your suggested naming-scheme.

Additionally I can check if the RemoveAll is easy to implement, I have to see if I can spare enough time for that feature.

[deitch]

@ludelion5 sorry to send you on a bit of a U turn. #264 was merged a few days ago, which extends the general interface with support for remove and rename, specifically as fs.Remove() and fs.Rename(). To keep fat32 compliant, it just made this not supported, same for ext4 and squashfs. Can you simplify this PR to just change the implementation of Remove() and Rename() in fat32? The others are not needed.

[ludelion5]

Sorry for the late update on this PR.

We adapted our Rename and Remove methods to the new interface.

Additionally we have implemented the ability to remove empty directories and the renaming to already existing files (overwriting).
Currently, the renaming (move) works only in the same directory, this would require a deeper understanding of your fs.allocateSpace, I guess this method has to be called multiple times, depending on how many directory levels the file moves. We check if the base-dir is different and return an error.

[aol-nnov]

As the method got implemented, lint exception is not needed anymore here. Please remove it.

[deitch]

Currently, the renaming (move) works only in the same directory, this would require a deeper understanding of your fs.allocateSpace, I guess this method has to be called multiple times, depending on how many directory levels the file moves. We check if the base-dir is different and return an error

That certainly is enough for now. We go from "this is not implemented" to "this is partially implemented", which his an improvement. So thank you.

[deitch]

Just the lint comment.

[ludelion5]

done

[deitch]

Just some lint errors that need to be fixed.

[ludelion5]

make lint should now be satisfied

[deitch]

Looks great, thanks!

[ludelion5]

are you planning to create a new tag as well?

[deitch]

Yeah but let's wait for this one.

[ludelion5]

Do you have an estimation when a new tag is created?

[deitch]

We can cut one now. We have the extended filesystem interface, this, go 1.22 restored support, some fixed, etc.

[deitch]

https://github.com/diskfs/go-diskfs/releases/tag/v1.5.0