Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock Detected in bulk update payments. #433

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Deadlock Detected in bulk update payments. #433

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b411683
refactor the update payment function
hemant10yadav Nov 14, 2024
c552c34
Merge remote-tracking branch 'refs/remotes/origin/main' into hy/deadl…
hemant10yadav Nov 26, 2024
ad592fe
used cache lock to avoid deadlock in postgres
hemant10yadav Nov 26, 2024
1ae5ce2
removed comment
hemant10yadav Nov 26, 2024
48ead78
changed timeout to 5 minutes
hemant10yadav Nov 28, 2024
194c1aa
timeout to 10 mins
hemant10yadav Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion commcare_connect/opportunity/visit_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,12 +271,18 @@ def _bulk_update_payments(opportunity: Opportunity, imported_data: Dataset) -> P
payment = Payment.objects.create(opportunity_access=access, amount=amount, amount_usd=amount_usd)
seen_users.add(username)
payment_ids.append(payment.pk)
update_work_payment_date(access)
process_work_payment_dates(users)
hemant10yadav marked this conversation as resolved.
Show resolved Hide resolved
missing_users = set(usernames) - seen_users
send_payment_notification.delay(opportunity.id, payment_ids)
return PaymentImportStatus(seen_users, missing_users)


def process_work_payment_dates(accesses: list):
with transaction.atomic():
for oa in accesses:
update_work_payment_date(oa)


def _cache_key(currency_code, date=None):
return [currency_code, date.toordinal() if date else None]

Expand Down
Loading