Deadlock Detected in bulk update payments. #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravfeyn
approved these changes
Nov 18, 2024
|
How does this address the issue? If wrapping the whole thing in a transaction does not prevent locks, why would a second nested transaction? |
pxwxnvermx
reviewed
Nov 26, 2024
calellowitz
approved these changes
Dec 9, 2024
| payment_ids.append(payment.pk) | ||
| update_work_payment_date(access) | ||
| lock_key = f"bulk_update_payments_opportunity_{opportunity.id}" | ||
| with cache.lock(lock_key, timeout=300): |
There was a problem hiding this comment.
How confident are you this timeout is long enough? I would have guessed some of the really big ones, might exceed this, or at least come close.
There was a problem hiding this comment.
I recently faced this. I think we can aim for around 10 minutes that should be sufficient, I guess.
pxwxnvermx
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCCT-549
Sentry link
transaction.atomic()block only ensures atomicity within a single Celery task, but does not prevent deadlocks between multiple concurrent tasks.To resolve this, I have used cache lock so that only one bulk update payment is allowed at a time.