Merge pull request #2906 from dimagi/logImageSaveError

logs exceptions encountered while saving image
dimagi · Dec 4, 2024 · a90c404 · a90c404
2 parents d60d242 + 3ed066a
commit a90c404
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/app/src/org/commcare/activities/components/ImageCaptureProcessing.java b/app/src/org/commcare/activities/components/ImageCaptureProcessing.java
@@ -127,7 +127,7 @@ public static boolean processCaptureResponse(FormEntryActivity activity,
         try {
             return scaleAndSaveImage(originalImage, isImage, instanceFolder, activity);
         } catch (IOException e) {
-            e.printStackTrace();
+            Logger.exception("Error while trying to save captured image", e);
             Toast.makeText(activity, Localization.get("image.capture.not.saved"), Toast.LENGTH_LONG).show();
             return false;
         }
@@ -177,12 +177,9 @@ private static void processImageGivenFileUri(FormEntryActivity activity, String
         } catch (FileExtensionNotFoundException e) {
             Logger.exception("Error while processing chosen image ", e);
             Toast.makeText(activity, Localization.get("image.selection.invalid.extension"), Toast.LENGTH_LONG).show();
-            return;
         } catch (IOException e) {
-            e.printStackTrace();
             Logger.exception("Error while processing chosen image ", e);
             Toast.makeText(activity, Localization.get("image.selection.not.saved"), Toast.LENGTH_LONG).show();
-            return;
         }
     }
 
@@ -198,7 +195,7 @@ private static void processImageGivenFilePath(FormEntryActivity activity, String
             try {
                 scaleAndSaveImage(originalImage, true, instanceFolder, activity);
             } catch (IOException e) {
-                e.printStackTrace();
+                Logger.exception("Error while saving chosen image ", e);
                 Toast.makeText(activity, Localization.get("image.selection.not.saved"), Toast.LENGTH_LONG).show();
             }
         } else {