Merge pull request #2903 from dimagi/entityCacheLimitation

Remove misleading comment reg. 1 MB Sql Limitation
dimagi · Dec 4, 2024 · d60d242 · d60d242
2 parents bbb7a96 + e662e56
commit d60d242
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/app/src/org/commcare/models/database/user/models/CommCareEntityStorageCache.java b/app/src/org/commcare/models/database/user/models/CommCareEntityStorageCache.java
@@ -254,9 +254,6 @@ private static String buildKeyNameWhereClause(String[] names) {
 
     private static void populateEntitySet(SQLiteDatabase db, String sqlStatement, String[] args,
             Hashtable<String, AsyncEntity> entitySet) {
-        //TODO: This will _only_ query up to about a meg of data, which is an un-great limitation.
-        //Should probably split this up SQL LIMIT based looped
-        //For reference the current limitation is about 10k rows with 1 field each.
         Cursor walker = db.rawQuery(sqlStatement, args);
         while (walker.moveToNext()) {
             String entityId = walker.getString(walker.getColumnIndex("entity_key"));