-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prettier and run prettier command via lint-staged #448
Conversation
here are the changes that are made by prettier. maskeynihal#1 should I also push the changes? @MattIPv4? the test failing should fixed by the changes. |
I think you'll probably want to add a dedicated test step for prettier -- eslint is definitely not flagging all the issues. And yeah, a commit with all the changes prettier wants would be good as well. |
run prettier and eslint fix on whole project with .js and .vue extension
@MattIPv4 All the checks are passing.
I didn't get what you meant by this. |
You'll want to add a new GitHub Actions test check for prettier -- eslint did fail, but it definitely did not fail with everything that prettier wanted to change. |
6a474d4
to
1aa8b23
Compare
@MattIPv4 I have added github action to check code by prettier. Should we restrict the use of the "prettier" check to only Thanks for taking the time to look into the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm!
@MattIPv4 Would you mind adding the "hacktoberfest" tag to this PR if you can? It would be fantastic for keeping track of contributions during Hacktoberfest, but don't worry if you can't. I'm thrilled to contribute either way! |
The repository already has the |
@MattIPv4 Gotcha. Thanks. Previously it was showing Thanks once again. |
Type of Change
What issue does this relate to?
resolves #447
What should this PR do?
prettier
prettier
using lint-staged when creating a new git commitnpm run prettier
should style the issue by prettiernpm run prettier:check
should check if there is any error and give a list of files that have errors.What are the acceptance criteria?
prettier
should run in only the files that are changed when a new git commit is added.test prettier
CI should run on PR and it should pass before merging the code.