-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow independent scrolling in split-column mode #433
Allow independent scrolling in split-column mode #433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could we apply this styling in the SCSS, rather than mixing inline styles with classes?
@MattIPv4 What should we do for "Back to top" button? |
Good question -- what do you think would be the best UX? I'm thinking it should scroll the document, and both the columns, back to the top? |
@MattIPv4 I have updated the copyright year to 2023. Should I update the copyright year on every file of the whole repo? |
Yes, that sounds right. Should I do that in this PR or in another PR? |
Only the files you have touched in this PR, please
It'd be great to do it in this PR, please, as it's related to the change being made here |
@MattIPv4 I have updated the code. Now, the independent column also scrolls when "Back to top" is clicked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty
Type of Change
What issue does this relate to?
resolves #430
What should this PR do?
overflowY: auto
andheight: 100vh
for each column so that it can be scrolled horizontally.What are the acceptance criteria?
Side-by-side
mode.Before
Before.independent.scroll.mov
After
Independent.scroll.mov