Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DevShop YamlTasks & GitHub API CLI for Deployments #1304

Closed
wants to merge 104 commits into from

Conversation

jonpugh
Copy link
Contributor

@jonpugh jonpugh commented Mar 23, 2020

Description

Replaces provision-ops/yaml-tests with devshop/yaml-tasks.

Includes fixes for

Testing done

  • CI Tests

QA steps

  1. Ensure tests are run and GitHub Statuses are being passed with correct links to this PR.

Definition of Done

@jonpugh
Copy link
Contributor Author

jonpugh commented Mar 24, 2020

Strange. Getting package incompatibility error when running on CMS-CI:

 [ErrorException]                                                                                                                                                                        
  Declaration of DevShop\Component\PowerProcess\PowerProcess::mustRun(?callable $callback = NULL) should be compatible with Symfony\Component\Process\Process::mustRun($callback = NULL)  

However composer yaml-tasks works for me locally, on php7.2.

@ElijahLynn ElijahLynn mentioned this pull request Mar 24, 2020
14 tasks
@jonpugh jonpugh requested a review from swirtSJW March 24, 2020 19:00
@jonpugh jonpugh closed this Mar 24, 2020
@jonpugh jonpugh reopened this Mar 24, 2020
@ElijahLynn
Copy link
Contributor

Seeing this error on test run 20 minutes ago, if you could fix:

[error] Conflict merging master into f8b5dcf.

And, unrelated to this PR (it seems) and I will work on fixing this (confused why it is only visible on this PR though):

Step 24 start: Build Webpack assets
...
ERROR in ./src/applications/proxy-rewrite/sass/style-consolidated.scss
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):

Is because the yarn install at the beginning failed with:

4/4] Building fresh packages...
error /var/aegir/projects/cms/pr1304/docroot/vendor/va-gov/web/node_modules/chromedriver: Command failed.
Exit code: 1
Command: node install.js
Arguments:
Directory: /var/aegir/projects/cms/pr1304/docroot/vendor/va-gov/web/node_modules/chromedriver
Output:
Downloading https://chromedriver.storage.googleapis.com/2.38/chromedriver_linux64.zip
Saving to /tmp/chromedriver/chromedriver_linux64.zip
Using npmconf ca
ChromeDriver installation failed Error with http(s) request: Error: write EPROTO 139628449326976:error:1425F175:SSL routines:ssl_choose_client_version:inappropriate fallback:../deps/openssl/openssl/ssl/statem/statem_lib.c:1951:
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Script export NODE_EXTRA_CA_CERTS=/etc/pki/tls/certs/ca-bundle.crt PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=TRUE; cd web && yarn install handling the va:web:install event returned with error code 1
Script @va:web:install was called via post-install-cmd

Jon and I debugged this a bit today and I had shared what I debugged a while ago, which was that the post-yarn install commands that were triggering node install.js were actually using the system node (v13) not our application node(v10.5). And it appears there was something going on with the PATH in this refactor of yaml-tasks that changed. Jon removed the global DevShop node and it got past this step successfully now.

@ElijahLynn ElijahLynn changed the title Implement DevShop YamlTasks & GitHub API CLI for Deployments Implement DevShop YamlTasks & GitHub API CLI for CI Deployments May 5, 2020
@ElijahLynn ElijahLynn changed the title Implement DevShop YamlTasks & GitHub API CLI for CI Deployments Implement DevShop YamlTasks & GitHub API CLI for Deployments May 5, 2020
@ElijahLynn ElijahLynn modified the milestones: CMS Sprint 3, CMS Sprint 6 May 8, 2020
@kevwalsh kevwalsh removed this from the CMS Sprint 6 milestone May 26, 2020
@ElijahLynn ElijahLynn assigned ElijahLynn and unassigned jonpugh Jul 9, 2020
@ElijahLynn ElijahLynn added this to the CMS Sprint 11 milestone Jul 9, 2020
@cmaeng cmaeng closed this Aug 3, 2020
@ElijahLynn ElijahLynn deleted the VAGOV-1229-devshop-yaml-tasks branch March 22, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps CMS team practice area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants