Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer / NodeJS Installer / Move to Suggests #579

Merged
merged 23 commits into from
Apr 24, 2020
Merged

Conversation

jonpugh
Copy link
Member

@jonpugh jonpugh commented Apr 22, 2020

Adding node via the nodejs installer was clever. Too clever. By half.

Removing npm/node fixed a problem with the web builds in department-of-veterans-affairs/va.gov-cms#1304

Let's move it to "suggests" instead.

@devshopbot devshopbot had a problem deploying to github.pr579.centos7 April 22, 2020 19:21 Failure
@devshopbot devshopbot had a problem deploying to github.pr579.ubuntu1804 April 22, 2020 19:21 Failure
… Traits used on robo command files cannot have methods that dont parse as AnnotatedCommands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants