Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup venv even if command fails #133

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Cleanup venv even if command fails #133

merged 3 commits into from
Oct 16, 2023

Conversation

emilwareus
Copy link
Contributor

No description provided.

@emilwareus emilwareus requested a review from sweoggy October 15, 2023 14:55
@emilwareus emilwareus marked this pull request as draft October 15, 2023 15:07
@emilwareus emilwareus linked an issue Oct 15, 2023 that may be closed by this pull request
Python virtual env not removed if resolve fails #132
Closed
sweoggy
sweoggy requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@sweoggy sweoggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test which asserts that venv goes away on failure?

Looks good otherwise!

@github-actions
Copy link

CodeScene PR Check

View detailed results in CodeScene
Code Health Quality Gates ✅ OK
Recommended Review Level Lightweight sanity check
Declining Code Health 0 findings(s) 🚩
Improving Code Health 1 findings(s) ✅
Affected Hotspots 2 files(s) 🔥

✅ Improving Code Health:

  • Bumpy Road Ahead job.go: Run 🔥

@emilwareus
Copy link
Contributor Author

Could you add a test which asserts that venv goes away on failure?

Looks good otherwise!

Added one now, if you revert the fix in job.go it should fail

@emilwareus emilwareus requested a review from sweoggy October 16, 2023 07:29
@emilwareus emilwareus marked this pull request as ready for review October 16, 2023 07:57
@sweoggy sweoggy merged commit fe678f6 into main Oct 16, 2023
8 checks passed
@sweoggy sweoggy deleted the pip-venv-cleanup branch October 16, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweoggy sweoggy sweoggy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python virtual env not removed if resolve fails
2 participants
@emilwareus @sweoggy