skip deletion of venv when it has not been created yet

debricked · Oct 15, 2023 · a5bd8c4 · a5bd8c4
1 parent 64f1fde
commit a5bd8c4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/internal/resolution/pm/pip/job.go b/internal/resolution/pm/pip/job.go
@@ -61,6 +61,9 @@ func (j *Job) Install() bool {
 func (j *Job) Run() {
 	if j.install {
 		defer func() {
+			if j.venvPath == "" {
+				return
+			}
 			j.SendStatus("removing venv")
 			err := j.pipCleaner.RemoveAll(j.venvPath)
 			if err != nil {

diff --git a/internal/resolution/pm/pip/job_test.go b/internal/resolution/pm/pip/job_test.go
@@ -66,7 +66,7 @@ func TestRunInstallCmdErr(t *testing.T) {
 	cmdFactoryMock := testdata.NewEchoCmdFactory()
 	cmdFactoryMock.MakeInstallErr = cmdErr
 	fileWriterMock := &writerTestdata.FileWriterMock{}
-	j := NewJob("file", true, cmdFactoryMock, fileWriterMock, nil)
+	j := NewJob("file", true, cmdFactoryMock, fileWriterMock, pipCleaner{})
 
 	go jobTestdata.WaitStatus(j)
 	j.Run()