Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2-how-we-style-our-sql.md #6614

Closed
wants to merge 3 commits into from
Closed

Update 2-how-we-style-our-sql.md #6614

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6899619
Update 2-how-we-style-our-sql.md
Vhonani-Nelwamondo Dec 9, 2024
a1de14b
Merge branch 'current' into patch-1
mirnawong1 Dec 10, 2024
edfe42a
Merge branch 'current' into patch-1
mirnawong1 Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion website/docs/best-practices/how-we-style/2-how-we-style-our-sql.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ id: 2-how-we-style-our-sql

- 🔙 Fields should be stated before aggregates and window functions.
- 🤏🏻 Aggregations should be executed as early as possible (on the smallest data set possible) before joining to another table to improve performance.
- 🔢 Ordering and grouping by a number (eg. group by 1, 2) is preferred over listing the column names (see [this classic rant](https://www.getdbt.com/blog/write-better-sql-a-defense-of-group-by-1) for why). Note that if you are grouping by more than a few columns, it may be worth revisiting your model design.
- 🔢 Ordering and grouping by column names and not Group by 1,2,3 this works on adhoc sql queries and not SQL queries you use in production.

## Joins

Expand Down
Loading