Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2-how-we-style-our-sql.md #6614

Closed

Conversation

Vhonani-Nelwamondo
Copy link

@Vhonani-Nelwamondo Vhonani-Nelwamondo commented Dec 9, 2024

Group by column names

What are you changing in this pull request and why?

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

Group by column names
@Vhonani-Nelwamondo Vhonani-Nelwamondo requested a review from a team as a code owner December 9, 2024 07:15
Copy link

welcome bot commented Dec 9, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 10, 2024 10:07am

Copy link

vercel bot commented Dec 9, 2024

@Vhonani-Nelwamondo is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Dec 9, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Dec 9, 2024
@mirnawong1
Copy link
Contributor

hey @Vhonani-Nelwamondo , thanks for opening this pr up and great initiative!

grouping by is definitely a matter of preference and our best practice stance is to group by number, not column name. we explain our reasons in our article here.

since this change doesn’t align with our best practices, i’ll go ahead and close this PR. however, we really appreciate your effort, and we’d love to see more contributions from you in the future. if you have other ideas or edits in mind, feel free to submit them — we’re always excited to collaborate!

thanks again for your contribution! 🙌

@mirnawong1 mirnawong1 closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants