Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nfiann-prerelease #6502
base: current
Are you sure you want to change the base?
Nfiann-prerelease #6502
Changes from 4 commits
92c1d65
62a91d5
10c07c9
8998396
5a6f70f
3be97b9
301f7d0
1e5b5bb
d5bce3d
7d14815
be5a954
566fe06
24e2f96
4e69098
a958413
73f24c1
8e68a5c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first two commands look like they will upgrade the install of
pip
and then verify the version. The last line is the output rather than a command itself.Recommendation is to either cut this section entirely or to update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as https://github.com/dbt-labs/docs.getdbt.com/pull/6502/files#r1861140005
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know i mentioned linking to the github issue but maybe it's more direct to link them to the repo which has the toggles?
maybe that's more of a doug question to confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than link to a GitHub Discussion or repo, I think we should either: