-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nfiann-prerelease #6502
base: current
Are you sure you want to change the base?
Nfiann-prerelease #6502
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
</Expandable> | ||
|
||
If you’re using a different operating system, refer to [Git issue on Instructions to create a python virtual environment](https://github.com/dbt-labs/docs.getdbt.com/discussions/2143) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know i mentioned linking to the github issue but maybe it's more direct to link them to the repo which has the toggles?
maybe that's more of a doug question to confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than link to a GitHub Discussion or repo, I think we should either:
- exclude the instructions and exclude the links
- explicitly include the instructions for other operating system shells
Co-authored-by: Mirna Wong <[email protected]>
Co-authored-by: Mirna Wong <[email protected]>
Co-authored-by: Mirna Wong <[email protected]>
These commands will install the prerelease: | ||
|
||
```shell | ||
python3 -m pip install --upgrade pip | ||
python3 -m pip --version | ||
pip 23.3.1 from .../.venv/lib/python3.9/site-packages (python 3.9) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first two commands look like they will upgrade the install of pip
and then verify the version. The last line is the output rather than a command itself.
Recommendation is to either cut this section entirely or to update it.
These commands will install the prerelease: | ||
|
||
```shell | ||
py -m pip install --upgrade pip | ||
py -m pip --version | ||
pip 23.3.1 from .venv\lib\site-packages (Python 3.9.4) | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python3 -m venv venv | ||
source venv/bin/activate | ||
python3 -m pip install --upgrade pip | ||
python3 -m pip install --pre dbt-core dbt-adapter-name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the key part, and it looks good 👍
python3 -m pip install --pre dbt-core dbt-adapter-name
Note: it will also install any pre-releases of all dependencies.
Co-authored-by: Doug Beatty <[email protected]>
Querying commands for operating systems here: https://dbt-labs.slack.com/archives/C05FWBP9X1U/p1732882329473009 |
``` | ||
Note, this will also install any pre-releases of all dependencies. | ||
|
||
#### Install prereleases of dbt-adapters on different operating systems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[custom.SentenceCaseHeaders] 'Install prereleases of dbt-adapters on different operating systems' should use sentence-style capitalization. Try 'Install prereleases of dbt adapters on different operating systems' instead.
|
||
### Install prereleases of dbt-adapters | ||
|
||
dbt-adapters are only compatible with dbt Core 1.8+. If you are on dbt Core v1.7 or below, follow the steps to upgrade to v1.8+ to install prereleases of dbt-adapters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[custom.Typos] Oops there's a typo -- did you really mean 'v1.7'?
|
||
### Install prereleases of dbt-adapters | ||
|
||
dbt-adapters are only compatible with dbt Core 1.8+. If you are on dbt Core v1.7 or below, follow the steps to upgrade to v1.8+ to install prereleases of dbt-adapters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[custom.Typos] Oops there's a typo -- did you really mean 'v1.8+'?
What are you changing in this pull request and why?
I've created this PR following Git issue: #2144 This is one of two PRs - the second will be a new doc
This PR provides users with instructions on installing pre-releases.
Checklist
🚀 Deployment available! Here are the direct links to the updated files: