Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#990] flake8 smells #991

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[#990] flake8 smells #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb72826
chore: ignore pipenv artifacts
danphenderson Feb 21, 2024
495692f
chore: cleanup irrelevant flake8 exclude statement
danphenderson Feb 21, 2024
d7d8caa
fix: flake8 code smells
danphenderson Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ ignore =
E203,
E741,
E501,
exclude = test
E231,
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ test.env
# pycharm
.idea/

# Pipenv
Pipfile.lock
Pipfile

# MacOS
.DS_Store

Expand Down
2 changes: 1 addition & 1 deletion dbt/adapters/spark/impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def list_relations_without_caching(self, schema_relation: BaseRelation) -> List[
)
except DbtRuntimeError as e:
errmsg = getattr(e, "msg", "")
if f"Database '{schema_relation}' not found" in errmsg:
if f"Database '{schema_relation}' not found" in errmsg: # noqa: E713
return []
# Iceberg compute engine behavior: show table
elif "SHOW TABLE EXTENDED is not supported for v2 tables" in errmsg:
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def generate_name_macros(package):
else:
source = f"target.{component}"
name = f"generate_{component}_name"
sql = f"{{% macro {name}(value, node) %}} {{% if value %}} {{{{ value }}}} {{% else %}} {{{{ {source} }}}} {{% endif %}} {{% endmacro %}}"
sql = f"{{% macro {name}(value, node) %}} {{% if value %}} {{{{ value }}}} {{% else %}} {{{{ {source} }}}} {{% endif %}} {{% endmacro %}}" # noqa: E201, E202
name_sql[name] = sql

for name, sql in name_sql.items():
Expand Down
Loading