[#990] flake8 smells

[danphenderson]

resolves issue #990

Solution

These code smells are no longer present:

dbt/adapters/spark/column.py:59:42: E231 missing whitespace after ':'
dbt/adapters/spark/column.py:60:42: E231 missing whitespace after ':'
dbt/adapters/spark/column.py:61:42: E231 missing whitespace after ':'
dbt/adapters/spark/column.py:62:42: E231 missing whitespace after ':'
dbt/adapters/spark/impl.py:239:47: E713 test for membership should be 'not in'
dbt/adapters/spark/python_submissions.py:50:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:64:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:96:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:118:31: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:129:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:197:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:211:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:232:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:248:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:291:64: E231 missing whitespace after ':'
tests/unit/utils.py:242:72: E201 whitespace after '{'
tests/unit/utils.py:242:78: E202 whitespace before '}'
tests/unit/utils.py:242:101: E201 whitespace after '{'
tests/unit/utils.py:242:110: E202 whitespace before '}'

I decided it would be better to ignore E231 instead of adding # noqa: E231 in a lot of places.

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: danphenderson.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[danphenderson]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!