-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added server side parameters for thrift connection type #577
Added server side parameters for thrift connection type #577
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Hanna Liashchuk.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Hanna Liashchuk.
|
Hi @rhousewright @drewbanin, could you please review this PR? |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Шкаберда Вадим Миколайович.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Шкаберда Вадим Миколайович.
|
1 similar comment
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Шкаберда Вадим Миколайович.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Шкаберда Вадим Миколайович.
|
712dbb9
to
ac1402c
Compare
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Шкаберда Вадим Миколайович.
|
ac1402c
to
e8bc6cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description has been added already to the Apache Spark Profile in Dbt docs.
Hi @hanna-liashchuk, thanks so much for your contribution. Your approach is to re-purpose I have a preference for your approach as it makes the |
@Fleid Agree, I think keeping the same name for the parameter is more user and documentation friendly. |
Hey @hanna-liashchuk, sorry for the delay, but we're still weighing options. |
@Fleid : This one is ready to merge. I expect a rebase is needed on main to fix the CI. Could you or @colin-rogers-dbt fix this? |
…hrift Minor change: line length and commas.
@Fleid @JCZuurmond |
resolves #387
Description
PR allows passing spark/hive configurations for thrift connections via server_side_parameters in the profiles file.
Checklist
changie new
to create a changelog entry