Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Added server_side_parameters for thrift connection method" #2711

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Revert "Added server_side_parameters for thrift connection method" #2711

merged 2 commits into from
Jan 19, 2023

Conversation

hanna-liashchuk
Copy link
Contributor

Reverts #2629

@hanna-liashchuk hanna-liashchuk requested review from a team and dataders as code owners January 17, 2023 14:53
@netlify
Copy link

netlify bot commented Jan 17, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 25bf534
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/63c993e282835400095254c7
😎 Deploy Preview https://deploy-preview-2711--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 17, 2023
@runleonarun
Copy link
Collaborator

Per original PR:

hi @dataders, this PR is related to the new feature dbt-labs/dbt-spark#577
the original PR wasn't merged yet :(

We'll get this reverted!

runleonarun
runleonarun approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to Revert until the new feature is shipped!

@runleonarun runleonarun merged commit 1af5391 into dbt-labs:current Jan 19, 2023
runleonarun added a commit that referenced this pull request Jan 19, 2023
@runleonarun
Revert "Revert "Added server_side_parameters for thrift connection me…
0ea39e1 
…thod" (#2711)"

This reverts commit 1af5391.
@runleonarun runleonarun mentioned this pull request Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun approved these changes

@dataders dataders Awaiting requested review from dataders

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanna-liashchuk @runleonarun