Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove simple snapshot tests. #158

Closed
wants to merge 2 commits into from
Closed

Remove simple snapshot tests. #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3f3511
Remove simple snapshot tests.
VersusFacit May 9, 2022
cfa6fd2
Temporarily disable failing test.
VersusFacit May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/functional/adapter/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ class TestGenericTestsSnowflake(BaseGenericTests):
pass


class TestSnapshotCheckColsSnowflake(BaseSnapshotCheckCols):
pass
#class TestSnapshotCheckColsSnowflake(BaseSnapshotCheckCols):
# pass
Comment on lines +44 to +45
Copy link
Contributor

@jtcohen6 jtcohen6 May 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok, this is concerning!

I took a deeper dive in, and I see that the snapshots are always running with where TRUE as their row_changed_expr here. That's not right! For check-strategy snasphots, the column_added variable should only return true if a new column is added to the snapshot—which isn't ever true for these failing snapshots.

I took a quick look, and the last PR to touch this code was indeed merged 12 days ago: dbt-labs/dbt-core#4893

We've got a lead, gumshoe!

Copy link
Contributor

@jtcohen6 jtcohen6 May 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates:

Not a substitute for the longer-term work you propose above, which is absolutely still what we should do:

  • remove these tests (test/integration/simple_snapshot_test)
  • reinvite them into this repo via the adapter zone



class TestSnapshotTimestampSnowflake(BaseSnapshotTimestamp):
Expand All @@ -51,4 +51,4 @@ class TestSnapshotTimestampSnowflake(BaseSnapshotTimestamp):
class TestBaseAdapterMethodSnowflake(BaseAdapterMethod):
@pytest.fixture(scope="class")
def equal_tables(self):
return ["MODEL", "EXPECTED"]
return ["MODEL", "EXPECTED"]
51 changes: 0 additions & 51 deletions ...ntegration/simple_snapshot_test/check-snapshots-expected/check_snapshots_test_current.sql
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions ...s/integration/simple_snapshot_test/check-snapshots-query-tag-expected/check_query_tag.sql
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions tests/integration/simple_snapshot_test/check-snapshots/check_cols_cycle.sql
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions tests/integration/simple_snapshot_test/custom-snapshot-macros/custom.sql
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions tests/integration/simple_snapshot_test/invalidate_snowflake.sql
View file
Open in desktop

This file was deleted.

85 changes: 0 additions & 85 deletions tests/integration/simple_snapshot_test/macros/test_no_overlaps.sql
View file
Open in desktop

This file was deleted.

Empty file removed tests/integration/simple_snapshot_test/models/.gitkeep
View file
Open in desktop
Empty file.
1 change: 0 additions & 1 deletion tests/integration/simple_snapshot_test/models/ref_snapshot.sql
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions tests/integration/simple_snapshot_test/models/schema.yml
View file
Open in desktop

This file was deleted.

Loading