Remove simple snapshot tests.

[VersusFacit]

Part 1 of fixing issue CT-600.

Description

After not finding a quick fix and in the interest of long-term optimization, I propose following through on Jerco's call to remove this test. After we remove these tests, we can reinvite them into this repo via the adapter zone.

In a "part 2 PR," I'll make sure the following tests are either accounted for in dbt core. Alternatively, they will be readded with the new framework in a so-called "part 3 PR" back into this repo:

• tests/integration/simple_snapshot_test/check-snapshots-query-tag-expected/check_query_tag.sql
• tests/integration/simple_snapshot_test/invalidate_snowflake.sql
• tests/integration/simple_snapshot_test/test_simple_snapshot.py::TestInvalidNamespacedCustomSnapshotFiles

I traced through every file removed and looked for matches in existing dbt-core code.

Checklist

• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have updated the CHANGELOG.md and added information about my change to the "dbt-snowflake next" section.

[jtcohen6]

Ah, ok, this is concerning!

I took a deeper dive in, and I see that the snapshots are always running with where TRUE as their row_changed_expr here. That's not right! For check-strategy snasphots, the column_added variable should only return true if a new column is added to the snapshot—which isn't ever true for these failing snapshots.

I took a quick look, and the last PR to touch this code was indeed merged 12 days ago: dbt-labs/dbt-core#4893

We've got a lead, gumshoe!

[jtcohen6]

Updates:

• Issue: [CT-619] [Bug] Column comparison in snapshot_check_all_get_existing_columns dbt-core#5222
• Proposed fix: Fix: column comparison logic for check-strategy snapshots dbt-core#5223

Not a substitute for the longer-term work you propose above, which is absolutely still what we should do:

• remove these tests (test/integration/simple_snapshot_test)
• reinvite them into this repo via the adapter zone

[leahwicz]

@VersusFacit is this the PR we can close out now as not needed?

[github-actions]

This PR has been marked as Stale because it has been open for 180 days with no activity. If you would like the PR to remain open, please remove the stale label or comment on the PR, or it will be closed in 7 days.