Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test already handled by core. #144

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Apr 24, 2022

Description

Per the note in Core issue CT-288, this is a test that need not belong in this repo and should therefore be removed with the migration of its dbt core counterpart. We call them custom_singular_tests now.

Only to be brought back to this repo in case some override of how custom tests is run in Snowflake specifically is needed one day.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR

@VersusFacit
Copy link
Contributor Author

Is a changelog entry needed for this?

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straight forward. 👍

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Oct 20, 2022
@VersusFacit
Copy link
Contributor Author

Failing because of a broken test in core. Assessing before merging.

@VersusFacit VersusFacit mentioned this pull request Oct 20, 2022
6 tasks
@VersusFacit VersusFacit merged commit 555d356 into main Oct 20, 2022
@VersusFacit VersusFacit deleted the remove_unneeded_data_test branch October 20, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants