fix test using custom global var #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
emmyoop
commented
Oct 20, 2022
| @@ -91,46 +92,6 @@ def _set_updated_at_to(self, delta): | |||
| self.last_inserted_time = insert_time.strftime( | |||
| "%Y-%m-%dT%H:%M:%S+00:00") | |||
|
|
|||
|
|
|||
| class TestSources(SuccessfulSourcesTest): | |||
There was a problem hiding this comment.
This doesn't actually run any tests...
There was a problem hiding this comment.
I agree this code doesn't run tests. However, it seems the subsequent test relies on method overrides in SuccessfulSourcesTest. I don't know enough about this test to know exactly what it wants to cover. Obviously this needs to be revised when it gets ported away from the integration framework.
I'm gonna close this PR, but I stole your patch for this PR and credited you/this PR directly in the commit 😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-core#5228
Description
This test uses the
DBT_ENV_CUSTOM_ENVwhich is now global. It needs to be reset in the test.Checklist
changie newto create a changelog entry