-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for IAM User auth #774
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide. |
mikealfare
commented
Apr 19, 2024
mikealfare
commented
Apr 19, 2024
mikealfare
commented
Apr 19, 2024
mikealfare
changed the title
Add integration tests for IAM User/Role auth
Add integration tests for IAM User auth
Apr 19, 2024
mikealfare
commented
Apr 19, 2024
4 tasks
Successful run with the new workflow: https://github.com/dbt-labs/dbt-redshift/actions/runs/8762024735/job/24112742150 |
mikealfare
commented
Apr 23, 2024
# Conflicts: # .github/workflows/integration.yml
mikealfare
commented
Apr 24, 2024
colin-rogers-dbt
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #760
Problem
We currently support IAM User auth but we don't currently have any tests that verify this.
Solution
redshift_connector
a profile name in your AWS config file)redshift_connector
the values that normally live in your AWS config file)test.env.example
so that contributors know what to provide to test this in their environmentChecklist