Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for IAM User auth #774

Merged
merged 40 commits into from
May 7, 2024
Merged

Add integration tests for IAM User auth #774

merged 40 commits into from
May 7, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Apr 18, 2024

resolves #760

Problem

We currently support IAM User auth but we don't currently have any tests that verify this.

Solution

  • add required infrastructure (users, roles, permissions, etc.) in AWS to support tests
  • add tests for Database method auth
  • add tests for IAM User method auth using a profile (give redshift_connector a profile name in your AWS config file)
  • add tests for IAM User method auth using direct args (give redshift_connector the values that normally live in your AWS config file)
  • update test.env.example so that contributors know what to provide to test this in their environment
  • clean up unit tests since (I got lost trying to find the applicable tests since they were all in "test_redshift_adapter")

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 18, 2024
@cla-bot cla-bot bot added the cla:yes label Apr 18, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@mikealfare mikealfare changed the title Add integration tests for IAM User/Role auth Add integration tests for IAM User auth Apr 19, 2024
@mikealfare mikealfare marked this pull request as ready for review April 19, 2024 23:38
@mikealfare mikealfare marked this pull request as draft April 19, 2024 23:38
@colin-rogers-dbt
Copy link
Contributor

Successful run with the new workflow: https://github.com/dbt-labs/dbt-redshift/actions/runs/8762024735/job/24112742150

@mikealfare mikealfare marked this pull request as ready for review April 23, 2024 03:30
@mikealfare mikealfare requested a review from a team April 25, 2024 02:56
@mikealfare mikealfare mentioned this pull request Apr 29, 2024
4 tasks
@mikealfare mikealfare merged commit 2d653c6 into main May 7, 2024
19 checks passed
@mikealfare mikealfare deleted the iam-auth branch May 7, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support IAM role and IAM user testing in CI
2 participants