Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IAM Role Authentication #781

Merged
merged 76 commits into from
May 8, 2024
Merged

Add IAM Role Authentication #781

merged 76 commits into from
May 8, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Apr 23, 2024 •
edited
Loading

resolves #623
continuation of #630
dependent on #774

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

abbywh and others added 28 commits October 16, 2023 10:48
@abbywh
adding SSO support for redshift
d4e05f6 
Committer: Abby Whittier <[email protected]>
@mikealfare @abbywh
ADAP-891: Support test results as views (#614)
a8ceb84 
* implement store-failures-as tests
@dbeatty10 @mikealfare @abbywh
Use the PID to terminate the session (#568)
48128e2 
* The first element of the result is the PID
* Debug-level logging of high-level message + SQL
* Using redshift_connector `cursor.fetchone()`  returns `(<something>,)`
* Use cursor to call `select pg_terminate_backend({pid})` directly rather than using the `SQLConnectionManager`

---------

Co-authored-by: Mike Alfare <[email protected]>
@abbywh
added error checking for new optional user field
dcc87c4
@colin-rogers-dbt
Merge branch 'main' into Feature/iamr_auth
a8a9118
@abbywh
black formatting
a60743c
@colin-rogers-dbt
Merge branch 'main' into Feature/iamr_auth
3b8ad21
@colin-rogers-dbt
Merge branch 'main' into Feature/iamr_auth
f657c94
@dataders
Merge branch 'main' into Feature/iamr_auth
c6f02be
@mikealfare
Merge branch 'main' into Feature/iamr_auth
d574ef4
@mikealfare
move connection fixtures into the functional scope
1175207
@mikealfare
add iam user creds to the test.env template
d85f503
@mikealfare
add test for database connection method
4255abe
@mikealfare
add iam user auth test
6eaa5ea
@mikealfare
Merge branch 'refs/heads/main' into iam-auth
8addeea
@mikealfare
add IAM User auth test and second user auth method
736fd1e
@mikealfare
changie
effdb6b
@mikealfare
Merge branch 'main' into iam-auth
6d57662
@mikealfare
maintain existing behavior when not providing profile
4c3dd3f
@mikealfare
Merge remote-tracking branch 'origin/iam-auth' into iam-auth
9a08786
@mikealfare
add AWS IAM profile
f87601f
@mikealfare
pull in new env vars
d55b6ee
@mikealfare
fixed env vars refs for CI
0501c53
@mikealfare
move all repo vars to secrets
f3697a7
@mikealfare
Merge branch 'refs/heads/main' into iam-auth
e97a2f6 
# Conflicts:
#	.github/workflows/integration.yml
@mikealfare
split out connect method by connection method and provided information
dbeb882
@mikealfare
condition to produce just kwargs, consolidate connect method
1f64811
@mikealfare
update .format to f-strings
228e318
@mikealfare mikealfare self-assigned this Apr 23, 2024
@cla-bot cla-bot bot added the cla:yes label Apr 23, 2024
mikealfare added 17 commits April 24, 2024 15:31
@mikealfare
Merge branch 'refs/heads/iam-auth' into iam-role-auth
92cfff0
@mikealfare
add required params to test profiles
83f9c66
@mikealfare
Merge branch 'refs/heads/iam-auth' into iam-role-auth
784b31d
@mikealfare
add required params to test profiles
796a9b2
@mikealfare
simplify test files
050ab08
@mikealfare
add expected fields back in
ec9e34e
@mikealfare
split out unit test files
8e0f654
@mikealfare
Merge branch 'refs/heads/iam-auth' into iam-role-auth
0ce0b81 
# Conflicts:
#	tests/functional/test_iam_role_auth.py
#	tests/unit/test_redshift_adapter.py
@mikealfare
split out unit test files
4c01ea1
@mikealfare
Merge branch 'refs/heads/iam-auth' into iam-role-auth
a70a6ff
@mikealfare
add unit tests for iam role auth method
ab8972a
@mikealfare
standardize names
dcc4f0c
@mikealfare
Merge branch 'refs/heads/iam-auth' into iam-role-auth
88d9ef8
@mikealfare
allow for the default profile
fbe4154
@mikealfare
add unit tests for iam role access
02c8695
@mikealfare
changie
e874434
@mikealfare
changie
93e6026
@mikealfare mikealfare marked this pull request as ready for review April 25, 2024 05:17
@mikealfare mikealfare requested a review from a team April 25, 2024 05:17
Base automatically changed from iam-auth to main May 7, 2024 23:26
@mikealfare
Merge branch 'refs/heads/main' into iam-role-auth
0f89f15 
# Conflicts:
#	dbt/adapters/redshift/connections.py
#	test.env.example
#	tests/functional/test_auth_method.py
#	tests/unit/test_auth_method.py
@colin-rogers-dbt colin-rogers-dbt merged commit 7e94b0a into main May 8, 2024
19 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the iam-role-auth branch May 8, 2024 00:46
@Fleid Fleid mentioned this pull request Jun 13, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes
Projects
None yet
Milestone
No milestone
5 participants
@mikealfare @colin-rogers-dbt @abbywh @dbeatty10 @dataders