Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Adapter Factory to Core #9274

Draft
wants to merge 16 commits into
base: feature/decouple-adapters-from-core
Choose a base branch
from

fix import broken on merge

f113d38
Select commit
Loading
Failed to load commit list.
Draft

Move Adapter Factory to Core #9274

fix import broken on merge
f113d38
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 12, 2023 in 0s

83.47% (-2.67%) compared to ed90356

View this Pull Request on Codecov

83.47% (-2.67%) compared to ed90356

Details

Codecov Report

Attention: 644 lines in your changes are missing coverage. Please review.

Comparison is base (ed90356) 86.14% compared to head (f113d38) 83.47%.
Report is 69 commits behind head on feature/decouple-adapters-from-core.

Files Patch % Lines
core/dbt/adapters/events/adapter_types_pb2.py 6.84% 177 Missing ⚠️
core/dbt/adapters/exceptions/compilation.py 43.75% 81 Missing ⚠️
core/dbt/events/core_types_pb2.py 16.90% 59 Missing ⚠️
core/dbt/adapters/events/types.py 84.38% 37 Missing ⚠️
core/dbt/common/exceptions/macros.py 52.30% 31 Missing ⚠️
core/dbt/common/clients/jinja.py 88.97% 29 Missing ⚠️
core/dbt/common/exceptions/cache.py 39.02% 25 Missing ⚠️
core/dbt/common/contracts/config/base.py 85.89% 22 Missing ⚠️
core/dbt/common/exceptions/base.py 86.25% 22 Missing ⚠️
core/dbt/common/utils/encoding.py 52.77% 17 Missing ⚠️
... and 37 more
Additional details and impacted files 
@@                           Coverage Diff                           @@
##           feature/decouple-adapters-from-core    #9274      +/-   ##
=======================================================================
- Coverage                                86.14%   83.47%   -2.67%     
=======================================================================
  Files                                      183      223      +40     
  Lines                                    26468    26973     +505     
=======================================================================
- Hits                                     22800    22517     -283     
- Misses                                    3668     4456     +788

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov