Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Adapter Factory to Core #9274

Draft
wants to merge 16 commits into
base: feature/decouple-adapters-from-core
Choose a base branch
from

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Dec 12, 2023

split adapters factory into client and load_adapter

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Dec 12, 2023
@colin-rogers-dbt colin-rogers-dbt changed the base branch from main to feature/decouple-adapters-from-core December 12, 2023 22:24
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 644 lines in your changes are missing coverage. Please review.

Comparison is base (ed90356) 86.14% compared to head (f113d38) 83.47%.
Report is 69 commits behind head on feature/decouple-adapters-from-core.

Files Patch % Lines
core/dbt/adapters/events/adapter_types_pb2.py 6.84% 177 Missing ⚠️
core/dbt/adapters/exceptions/compilation.py 43.75% 81 Missing ⚠️
core/dbt/events/core_types_pb2.py 16.90% 59 Missing ⚠️
core/dbt/adapters/events/types.py 84.38% 37 Missing ⚠️
core/dbt/common/exceptions/macros.py 52.30% 31 Missing ⚠️
core/dbt/common/clients/jinja.py 88.97% 29 Missing ⚠️
core/dbt/common/exceptions/cache.py 39.02% 25 Missing ⚠️
core/dbt/common/contracts/config/base.py 85.89% 22 Missing ⚠️
core/dbt/common/exceptions/base.py 86.25% 22 Missing ⚠️
core/dbt/common/utils/encoding.py 52.77% 17 Missing ⚠️
... and 37 more
Additional details and impacted files
@@                           Coverage Diff                           @@
##           feature/decouple-adapters-from-core    #9274      +/-   ##
=======================================================================
- Coverage                                86.14%   83.47%   -2.67%     
=======================================================================
  Files                                      183      223      +40     
  Lines                                    26468    26973     +505     
=======================================================================
- Hits                                     22800    22517     -283     
- Misses                                    3668     4456     +788     
Flag Coverage Δ
integration 83.47% <75.51%> (+0.42%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant