-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support labels for semantic_models, dimensions, measures and entities #8646
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8646 +/- ##
==========================================
+ Coverage 86.56% 86.61% +0.05%
==========================================
Files 175 175
Lines 25595 25604 +9
==========================================
+ Hits 22156 22177 +21
+ Misses 3439 3427 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
For anyone wondering, we can't test against the protocol yet for labels because dbt-semantic-interfaces hasn't released a version with them yet 🙃
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4114 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-8646-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e3dfb09b10f3027dde473af3352c36f0e16e92a8
# Push it to GitHub
git push --set-upstream origin backport-8646-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest Then, create a pull request where the |
…res and entities (#8729) Co-authored-by: Emily Rockman <[email protected]>
…#8646) * first pass * changelog * changelog * Delete .changes/unreleased/Features-20230913-155802.yaml * Update .changes/unreleased/Features-20230914-074429.yaml
resolves #8595
Problem
While
label
is required forMetric
nodes, it is not currently supported forSemanticModel
nodes,Dimensions
,Entities
andMeasures
.Solution
Add support for an optional
label
field.Checklist