-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional label
attribute protocols
#143
Comments
@nhandel should it be added to any other protocols? |
Do we need SemanticModel? It doesn't matter much to me either way, I think Metric, Dimension, and Measure are the most important. |
In the originally filed #139 users are requesting the label property be added to entities as well, so we need to consider how that might work. |
I think it's worth the extra effort to have consistency and add
Semantic layers should also have attributes for synonyms, formatting, and more, but I understand dbt doesn't want to be too opinionated. Like others, I'll just use the |
@QMalcolm this should also be added to the Entity object. We'll also need to add validation that each Entity with the same name either has the same label specified. |
@ataft support for |
@tlento I see from that issue that I was thinking/hoping that the new semantic layer could act as a "universal semantic layer" where I define everything (label, description, aggtype, meta for formatting and NLQ synonyms, etc.) that downstream tools could then just plug into. I was also hoping that the semantic layer YAML would replace the model and columns YAML, so I wouldn't need to define model columns and then separate measures and dimensions (seems redundant). Is the expectation that people will define a model and columns in one schema YAML file, then also define a semantic model with dimensions and metrics? |
We've added labels in dbt-labs/dbt-core#8646. It is no longer a blocker on labels being supported. |
dbt-core currently allows for specifying an optional
label
property on metric nodes. However we don't currently specify this on the metric protocol. MetricFlow would like to begin using this property, and would like it to exist on more objects.We should add an optional
label
property to the following protocols:The text was updated successfully, but these errors were encountered: