Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.7.latest] [Bug] Use a list instead of a set for index changes to perserve order (dbt-postgres#73) #10044

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare self-assigned this Apr 25, 2024
@mikealfare mikealfare requested a review from a team as a code owner April 25, 2024 18:51
@cla-bot cla-bot bot added the cla:yes label Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (40a54ff) to head (dc8cc96).

Additional details and impacted files
@@             Coverage Diff             @@
##           1.7.latest   #10044   +/-   ##
===========================================
  Coverage       86.64%   86.64%           
===========================================
  Files             179      179           
  Lines           26662    26662           
===========================================
  Hits            23102    23102           
  Misses           3560     3560           
Flag Coverage Δ
integration 83.47% <ø> (ø)
unit 65.07% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikealfare mikealfare requested a review from a team April 25, 2024 19:02
@mikealfare mikealfare merged commit 0322a4b into 1.7.latest Apr 25, 2024
61 checks passed
@mikealfare mikealfare deleted the backport/1.7.latest/postgres-73 branch April 25, 2024 23:04
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-10044-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0322a4b9b72385617fb2c73c58cce9efd5084c6a
# Push it to GitHub
git push --set-upstream origin backport-10044-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-10044-to-1.6.latest.

@martynydbt martynydbt self-requested a review April 25, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] unordered set causing statements to be executed in incorrect order
2 participants