Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] unordered set causing statements to be executed in incorrect order #72

Closed
2 tasks done
colin-rogers-dbt opened this issue Apr 25, 2024 · 1 comment · Fixed by #73, dbt-labs/dbt-core#10044 or dbt-labs/dbt-core#10047
Assignees
Labels
bug Something isn't working High Severity bug with significant impact that should be resolved in a reasonable timeframe

Comments

@colin-rogers-dbt
Copy link
Contributor

Is this a new bug?

  • I believe this is a new bug
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

We use a set object to store SQL statements to be executed as part of an index operation. Because this is unordered this will occassionally cause us to execute statements in the wrong order.
See:

def _get_index_config_changes(

Expected Behavior

Statements are ordered correctly

Steps To Reproduce

Run this a couple of times:

 hatch run integration-tests:all tests/functional/materializations/materialized_view_tests/test_materialized_view.py::TestPostgresMaterializedViewChangesApply

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-postgres:

Additional Context

No response

@colin-rogers-dbt colin-rogers-dbt added bug Something isn't working Highest Severity critical bug that must be resolved immediately labels Apr 25, 2024
@colin-rogers-dbt colin-rogers-dbt added High Severity bug with significant impact that should be resolved in a reasonable timeframe and removed Highest Severity critical bug that must be resolved immediately labels Apr 25, 2024
@mikealfare
Copy link
Contributor

Re-opening for the backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment