Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1271] Query Comment test conversion #333

Merged
merged 10 commits into from
Oct 12, 2022
Merged

[CT-1271] Query Comment test conversion #333

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8d16c4d
init pr 051 test conversion in bigquery
McKnight-42 Sep 30, 2022
897d168
Merge branch 'main' of https://github.com/dbt-labs/dbt-bigquery into …
McKnight-42 Oct 3, 2022
6d85117
update to main
McKnight-42 Oct 3, 2022
8abc1e5
remove old test
McKnight-42 Oct 3, 2022
0dbbd3e
Merge branch 'main' of https://github.com/dbt-labs/dbt-bigquery into …
McKnight-42 Oct 11, 2022
de8516f
Merge branch 'main' into mcknight/CT-1271-bq
McKnight-42 Oct 11, 2022
06fcff5
point back to main in core
McKnight-42 Oct 11, 2022
2b387cb
Merge branch 'mcknight/CT-1271-bq' of https://github.com/dbt-labs/dbt…
McKnight-42 Oct 11, 2022
a22f882
trying to fix the custom quota error
McKnight-42 Oct 11, 2022
2a54ea3
Merge branch 'main' into mcknight/CT-1271-bq
McKnight-42 Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# install latest changes in dbt-core
# TODO: how to automate switching from develop to version branches?
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
git+https://github.com/dbt-labs/dbt-core.git@mcknight/CT-1271#egg=dbt-core&subdirectory=core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove these after changes in core get merged

git+https://github.com/dbt-labs/dbt-core.git@mcknight/CT-1271#egg=dbt-tests-adapter&subdirectory=tests/adapter

black==22.8.0
bumpversion
Expand Down
29 changes: 29 additions & 0 deletions tests/functional/adapter/query_comment_test/test_query_comment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import pytest

from dbt.tests.adapter.query_comment.test_query_comment import (
BaseQueryComments,
BaseMacroQueryComments,
BaseMacroArgsQueryComments,
BaseMacroInvalidQueryComments,
BaseNullQueryComments,
BaseEmptyQueryComments,
)


class TestQueryCommentsBigQuery(BaseQueryComments):
pass

class TestMacroQueryCommentsBigQuery(BaseMacroQueryComments):
pass

class TestMacroArgsQueryCommentsBigQuery(BaseMacroArgsQueryComments):
pass

class TestMacroInvalidQueryCommentsBigQuery(BaseMacroInvalidQueryComments):
pass

class TestNullQueryCommentsBigQuery(BaseNullQueryComments):
pass

class TestEmptyQueryCommentsBigQuery(BaseEmptyQueryComments):
pass
25 changes: 0 additions & 25 deletions tests/integration/query_comments_test/macros/macro.sql
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions tests/integration/query_comments_test/models/x.sql
View file
Open in desktop

This file was deleted.

169 changes: 0 additions & 169 deletions tests/integration/query_comments_test/test_query_comments.py
View file
Open in desktop

This file was deleted.