Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1271] Query Comment test conversion #333

Merged
merged 10 commits into from
Oct 12, 2022
Merged

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Sep 30, 2022

resolves dbt-labs/dbt-core#5962
issue: dbt-labs/dbt-core#6272 (comment)

Description

Conversion of test 051 to a new functional test

Checklist

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Sep 30, 2022
@McKnight-42 McKnight-42 self-assigned this Sep 30, 2022
@cla-bot cla-bot bot added the cla:yes label Sep 30, 2022
@McKnight-42 McKnight-42 marked this pull request as ready for review October 3, 2022 14:45
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -1,7 +1,7 @@
# install latest changes in dbt-core
# TODO: how to automate switching from develop to version branches?
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
git+https://github.com/dbt-labs/dbt-core.git@mcknight/CT-1271#egg=dbt-core&subdirectory=core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove these after changes in core get merged

@McKnight-42 McKnight-42 merged commit ec61011 into main Oct 12, 2022
@McKnight-42 McKnight-42 deleted the mcknight/CT-1271-bq branch October 12, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1271] 051_query_comments_tests
2 participants