Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow copy_partitions when using microbatch #1421

Merged
merged 5 commits into from
Dec 10, 2024
Merged

[Feature] Allow copy_partitions when using microbatch #1421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e6af11
allowlist microbatch
borjavb Dec 2, 2024
d5435d3
add tests
borjavb Dec 2, 2024
5455196
Merge branch 'main' into 1414-microbatch-copy
MichelleArk Dec 5, 2024
634d79b
Update test_incremental_microbatch.py
borjavb Dec 7, 2024
a86e930
fix text
borjavb Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Features-20241202-223835.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Features
body: Allow copy_partitions in microbatch
time: 2024-12-02T22:38:35.479052Z
custom:
Author: borjavb
Issue: "1414"
4 changes: 2 additions & 2 deletions dbt/include/bigquery/macros/materializations/incremental.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@

{{ run_hooks(pre_hooks) }}

{% if partition_by.copy_partitions is true and strategy != 'insert_overwrite' %} {#-- We can't copy partitions with merge strategy --#}
{% if partition_by.copy_partitions is true and strategy not in ['insert_overwrite', 'microbatch'] %} {#-- We can't copy partitions with merge strategy --#}
{% set wrong_strategy_msg -%}
The 'copy_partitions' option requires the 'incremental_strategy' option to be set to 'insert_overwrite'.
The 'copy_partitions' option requires the 'incremental_strategy' option to be set to 'insert_overwrite' or 'microbatch'.
{%- endset %}
{% do exceptions.raise_compiler_error(wrong_strategy_msg) %}

Expand Down
18 changes: 18 additions & 0 deletions tests/functional/adapter/incremental/incremental_strategy_fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,3 +629,21 @@
}}
select * from {{ ref('input_model') }}
"""

microbatch_model_no_unique_id_copy_partitions_sql = """
{{ config(
materialized='incremental',
incremental_strategy='microbatch',
partition_by={
'field': 'event_time',
'data_type': 'timestamp',
'granularity': 'day',
'copy_partitions': true
},
event_time='event_time',
batch_size='day',
begin=modules.datetime.datetime(2020, 1, 1, 0, 0, 0)
)
}}
select * from {{ ref('input_model') }}
"""
7 changes: 7 additions & 0 deletions tests/functional/adapter/incremental/test_incremental_microbatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
microbatch_input_sql,
microbatch_model_no_partition_by_sql,
microbatch_model_invalid_partition_by_sql,
microbatch_model_no_unique_id_copy_partitions_sql,
microbatch_input_event_time_date_sql,
microbatch_input_event_time_datetime_sql,
)
Expand Down Expand Up @@ -79,3 +80,9 @@ def test_execution_failure_no_partition_by(self, project):
"The 'microbatch' strategy requires a `partition_by` config with the same granularity as its configured `batch_size`"
in stdout
)


class TestBigQueryMicrobatchWithCopyPartitions(BaseMicrobatch):
@pytest.fixture(scope="class")
def microbatch_model_sql(self) -> str:
return microbatch_model_no_unique_id_copy_partitions_sql
Loading