Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow copy_partitions when using microbatch #1421

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

borjavb
Copy link
Contributor

@borjavb borjavb commented Dec 2, 2024

resolves #
#1414

Problem

copy_partitions was only being allowed for insert_overwrite, but it makes sense to allowlist it when using microbatch too.

Solution

Allowlist copy_partitions as part of microbatch too.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@borjavb borjavb requested a review from a team as a code owner December 2, 2024 22:47
@cla-bot cla-bot bot added the cla:yes label Dec 5, 2024
@MichelleArk
Copy link
Contributor

MichelleArk commented Dec 5, 2024

code-quality fix looks pretty small, and I believe the unit test issue may be resolved with a merge to main given we've done work on retries recently: 26c19e9

@borjavb - Let me know if you can make those changes in the next day or two as we're planning the 1.9 final release of dbt-bigquery on December 12 and this would be awesome to include! Otherwise I can take it over the finish line (credit will still go to you in the Changelog :))

Edit: totally my bad, I wrote December 12 when I meant December 9. We'll get this out in a 1.9 patch though!

@borjavb
Copy link
Contributor Author

borjavb commented Dec 7, 2024

@MichelleArk Sorry, I was away from the computer for a few days! the code quality check should be fixed now 🙏 Added some extra tests to validate the set up too.

@borjavb borjavb force-pushed the 1414-microbatch-copy branch from aaf7477 to 8564305 Compare December 8, 2024 21:11
@borjavb borjavb force-pushed the 1414-microbatch-copy branch from 8564305 to a86e930 Compare December 8, 2024 22:13
@MichelleArk MichelleArk merged commit 827fc78 into dbt-labs:main Dec 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants