-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Allow copy_partitions
when using microbatch
#1421
Conversation
code-quality fix looks pretty small, and I believe the unit test issue may be resolved with a merge to main given we've done work on retries recently: 26c19e9 @borjavb - Let me know if you can make those changes in the next day or two as we're planning the 1.9 final release of dbt-bigquery on December 12 and this would be awesome to include! Otherwise I can take it over the finish line (credit will still go to you in the Changelog :)) Edit: totally my bad, I wrote December 12 when I meant December 9. We'll get this out in a 1.9 patch though! |
@MichelleArk Sorry, I was away from the computer for a few days! the code quality check should be fixed now 🙏 Added some extra tests to validate the set up too. |
aaf7477
to
8564305
Compare
8564305
to
a86e930
Compare
resolves #
#1414
Problem
copy_partitions
was only being allowed for insert_overwrite, but it makes sense to allowlist it when usingmicrobatch
too.Solution
Allowlist
copy_partitions
as part ofmicrobatch
too.Checklist