Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dbt-core install back to dev-requirements.txt #1082

Merged
merged 5 commits into from
Feb 2, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Jan 31, 2024

  • add dbt-core back to dev-requirements.txt

resolves #1080
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner January 31, 2024 23:34
@cla-bot cla-bot bot added the cla:yes label Jan 31, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare
Copy link
Contributor

@colin-rogers-dbt The failed tests are due to validating against the adapter version instead of the dbt-core version. Here's the fix in dbt-adapters, though it would need to be released for this CI to pick it up, unless we point this CI to GitHub.

@@ -1,5 +1,6 @@
# install latest changes in dbt-core
# TODO: how to automate switching from develop to version branches?
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want the dev version of dbt-adapters here too, right?

@colin-rogers-dbt colin-rogers-dbt merged commit 77a9f14 into main Feb 2, 2024
15 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the getCoreInDevReqs branch February 2, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Resolve broken proto build in CI
2 participants