-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point check back to dbt-core version instead of the adapter version #62
Conversation
I believe dbt_version is set here: https://github.com/dbt-labs/dbt-bigquery/blob/e86609a1e15a766eb764a535f277100ca10ee67b/dbt/adapters/bigquery/connections.py#L42 So it should be the adapter version not dbt-adapters or dbt-core |
see similar test patch: 8f259f5 Maybe we should add the adapter version as a global fixture? |
If you look at 1.7, this used to be the version of |
offline investigation shows that I'm incorrect and that the we need to settle on a more consistent approach to this field but for now I don't think adapters need to validate core's artifacts are generated correctly |
Are you suggesting we just remove the assertion (line 339) entirely? I'm also alright with this approach for exactly the argument you made. |
…ut rather a dbt-artifacts concern
Addresses failed CI in dbt-labs/dbt-bigquery#1082
Problem
The existing integration tests in
dbt-core
validated against thedbt-core
version, but the new integration tests tested against adapter version.Solution
Point the test back to
dbt-core
for now since that's our testing dependency anyway.Checklist