Create separate base classes for shared tests

.changes/unreleased/Fixes-20240216-135420.yaml

@@ -0,0 +1,6 @@
+kind: Fixes
+body: Make all adapter zone tests importable by removing "Test" prefix
+time: 2024-02-16T13:54:20.411864-05:00
+custom:
+  Author: mikealfare
+  Issue: "93"

dbt/tests/adapter/caching/test_caching.py

@@ -92,7 +92,7 @@ def test_cache(self, project):
         self.run_and_inspect_cache(project, run_args)
 
 
-class TestNoPopulateCache(BaseCachingTest):
+class BaseNoPopulateCache(BaseCachingTest):
     @pytest.fixture(scope="class")
     def models(self):
         return {
@@ -116,3 +116,7 @@ class TestCachingUppercaseModel(BaseCachingUppercaseModel):
 
 class TestCachingSelectedSchemaOnly(BaseCachingSelectedSchemaOnly):
     pass
+
+
+class TestNoPopulateCache(BaseNoPopulateCache):
+    pass

dbt/tests/adapter/column_types/test_column_types.py

@@ -15,11 +15,13 @@ def run_and_test(self):
         results = run_dbt(["test"])
         assert len(results) == 1
 
-
-class TestPostgresColumnTypes(BaseColumnTypes):
     @pytest.fixture(scope="class")
     def models(self):
         return {"model.sql": fixtures.model_sql, "schema.yml": fixtures.schema_yml}
 
     def test_run_and_test(self, project):
         self.run_and_test()
+
+
+class TestPostgresColumnTypes(BaseColumnTypes):
+    pass

dbt/tests/adapter/concurrency/test_concurrency.py

@@ -303,8 +303,6 @@ def models(self):
             "skip.sql": models__skip_sql,
         }
 
-
-class TestConcurenncy(BaseConcurrency):
     def test_concurrency(self, project):
         run_dbt(["seed", "--select", "seed"])
         results = run_dbt(["run"], expect_pass=False)
@@ -329,3 +327,7 @@ def test_concurrency(self, project):
         check_table_does_not_exist(project.adapter, "skip")
 
         assert "PASS=5 WARN=0 ERROR=1 SKIP=1 TOTAL=7" in output
+
+
+class TestConcurenncy(BaseConcurrency):
+    pass

dbt/tests/adapter/constraints/test_constraints.py

@@ -508,7 +508,7 @@ class TestConstraintQuotedColumn(BaseConstraintQuotedColumn):
     pass
 
 
-class TestIncrementalForeignKeyConstraint:
+class BaseIncrementalForeignKeyConstraint:
     @pytest.fixture(scope="class")
     def macros(self):
         return {
@@ -534,3 +534,7 @@ def test_incremental_foreign_key_constraint(self, project):
         run_dbt(["run", "--select", "raw_numbers"])
         run_dbt(["run", "--select", "stg_numbers"])
         run_dbt(["run", "--select", "stg_numbers"])
+
+
+class TestIncrementalForeignKeyConstraint(BaseIncrementalForeignKeyConstraint):
+    pass

dbt/tests/adapter/dbt_clone/test_dbt_clone.py

@@ -207,7 +207,7 @@ def clean_up(self, project):
     pass
 
 
-class TestCloneSameTargetAndState(BaseClone):
+class BaseCloneSameTargetAndState(BaseClone):
     def test_clone_same_target_and_state(self, project, unique_schema, other_schema):
         project.create_test_schema(other_schema)
         self.run_and_save_state(project.project_root)
@@ -220,3 +220,7 @@ def test_clone_same_target_and_state(self, project, unique_schema, other_schema)
 
         results, output = run_dbt_and_capture(clone_args, expect_pass=False)
         assert "Warning: The state and target directories are the same: 'target'" in output
+
+
+class TestCloneSameTargetAndState(BaseCloneSameTargetAndState):
+    pass

dbt/tests/adapter/dbt_debug/test_dbt_debug.py

@@ -49,7 +49,7 @@ def project_config_update(self):
         return {"config-version": 2, "profile": '{{ "te" ~ "st" }}'}
 
 
-class TestDebugPostgres(BaseDebug):
+class BaseDebugPostgres(BaseDebug):
     def test_ok(self, project):
         run_dbt(["debug"])
         assert "ERROR" not in self.capsys.readouterr().out
@@ -85,11 +85,11 @@ def test_empty_target(self, project):
         self.assertGotValue(re.compile(r"\s+output 'none_target'"), "misconfigured")
 
 
-class TestDebugProfileVariablePostgres(BaseDebugProfileVariable):
+class TestDebugPostgres(BaseDebugPostgres):
     pass
 
 
-class TestDebugInvalidProjectPostgres(BaseDebug):
+class BaseDebugInvalidProjectPostgres(BaseDebug):
     def test_empty_project(self, project):
         with open("dbt_project.yml", "w") as f:  # noqa: F841
             pass
@@ -128,3 +128,7 @@ def test_profile_not_found(self, project):
         )
         assert "Profile loading failed for the following reason" in out
         assert "Could not find profile named 'NONE'" in out
+
+
+class TestDebugInvalidProjectPostgres(BaseDebugInvalidProjectPostgres):
+    pass

dbt/tests/adapter/ephemeral/test_ephemeral.py

@@ -248,8 +248,6 @@ def models(self):
             },
         }
 
-
-class TestEphemeralMulti(BaseEphemeralMulti):
     def test_ephemeral_multi(self, project):
         run_dbt(["seed"])
         results = run_dbt(["run"])
@@ -281,7 +279,11 @@ def test_ephemeral_multi(self, project):
         assert sql_file == expected_sql
 
 
-class TestEphemeralNested(BaseEphemeral):
+class TestEphemeralMulti(BaseEphemeralMulti):
+    pass
+
+
+class BaseEphemeralNested(BaseEphemeral):
     @pytest.fixture(scope="class")
     def models(self):
         return {
@@ -314,7 +316,11 @@ def test_ephemeral_nested(self, project):
         assert sql_file == expected_sql
 
 
-class TestEphemeralErrorHandling(BaseEphemeral):
+class TestEphemeralNested(BaseEphemeralNested):
+    pass
+
+
+class BaseEphemeralErrorHandling(BaseEphemeral):
     @pytest.fixture(scope="class")
     def models(self):
         return {
@@ -330,3 +336,7 @@ def test_ephemeral_error_handling(self, project):
         assert len(results) == 1
         assert results[0].status == "skipped"
         assert "Compilation Error" in results[0].message
+
+
+class TestEphemeralErrorHandling(BaseEphemeralErrorHandling):
+    pass

dbt/tests/adapter/hooks/fixtures.py

@@ -360,3 +360,43 @@
 4,5,6
 7,8,9
 """
+
+
+tables__on_model_hook = """
+drop table if exists {schema}.on_model_hook;
+
+create table {schema}.on_model_hook (
+    test_state       TEXT, -- start|end
+    target_dbname    TEXT,
+    target_host      TEXT,
+    target_name      TEXT,
+    target_schema    TEXT,
+    target_type      TEXT,
+    target_user      TEXT,
+    target_pass      TEXT,
+    target_threads   INTEGER,
+    run_started_at   TEXT,
+    invocation_id    TEXT,
+    thread_id        TEXT
+);
+"""
+
+
+tables__on_run_hook = """
+drop table if exists {schema}.on_run_hook;
+
+create table {schema}.on_run_hook (
+    test_state       TEXT, -- start|end
+    target_dbname    TEXT,
+    target_host      TEXT,
+    target_name      TEXT,
+    target_schema    TEXT,
+    target_type      TEXT,
+    target_user      TEXT,
+    target_pass      TEXT,
+    target_threads   INTEGER,
+    run_started_at   TEXT,
+    invocation_id    TEXT,
+    thread_id        TEXT
+);
+"""