-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create separate base classes for shared tests #93
Conversation
… into adapter implementations without running automatically
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits
Good questions. I spent a good 15-30 minutes figuring out why the rename looked like it did. It turns out to be correct, but very misleading. So now we have the why captured in this PR. |
blocks dbt-labs/dbt-postgres#18
Problem
There are some tests in the "adapter zone" which do not have base classes. When these tests are imported, they run automatically due to how
pytest
works. This makes it impossible to configure the test if changes are required for a specific platform.Solution
pytest
to execute it)For example, this:
becomes:
Checklist