-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-5645 [EE\AWS] Change the instruction in the Version update tab #3017
Changes from 2 commits
ffa267f
098e823
a000e94
e3df810
3d21a92
6c53b90
809168a
1adc4ff
d660163
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/* | ||
* CloudBeaver - Cloud Database Manager | ||
* Copyright (C) 2020-2024 DBeaver Corp and others | ||
* | ||
* Licensed under the Apache License, Version 2.0. | ||
* you may not use this file except in compliance with the License. | ||
*/ | ||
export class GithubLinks { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems like its all static, we could convert it to const and function There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
static CLOUDBEAVER_REPO = 'https://github.com/dbeaver/cloudbeaver'; | ||
|
||
static EE_DEPLOY_UPDATE = 'https://github.com/dbeaver/cloudbeaver-deploy?tab=readme-ov-file#updating-the-cluster'; | ||
static TE_DEPLOY_UPDATE = 'https://github.com/dbeaver/team-edition-deploy?tab=readme-ov-file#server-version-update'; | ||
|
||
static getDeployUpdateLink(distributed: boolean) { | ||
if (distributed) { | ||
return GithubLinks.TE_DEPLOY_UPDATE; | ||
} | ||
|
||
return GithubLinks.EE_DEPLOY_UPDATE; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/* | ||
* CloudBeaver - Cloud Database Manager | ||
* Copyright (C) 2020-2024 DBeaver Corp and others | ||
* | ||
* Licensed under the Apache License, Version 2.0. | ||
* you may not use this file except in compliance with the License. | ||
*/ | ||
import { Link, useTranslate } from '@cloudbeaver/core-blocks'; | ||
|
||
import type { InstructionComponent } from './VersionUpdateService.js'; | ||
|
||
const SPLITTER = '*splitter*'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This splitter is confusing, why do we need it? Can we use \n or translate args? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. split to 2 locale keys. the best we can do here |
||
|
||
export const BaseUpdateInstruction: InstructionComponent = function UpdateInstruction({ version, containerId, link, className }) { | ||
const translate = useTranslate(); | ||
const mainText = translate('version_update_instruction').split(SPLITTER)[0]?.trim(); | ||
const linkText = translate('version_update_instruction').split(SPLITTER)[1]?.trim(); | ||
|
||
return ( | ||
<div className={className}> | ||
{mainText}{' '} | ||
<Link href={link} target="_blank" rel="noopener noreferrer" inline indicator> | ||
{linkText} | ||
</Link> | ||
</div> | ||
); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to rename the package? I think both has the similar meaning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was about our website dbeaver.com, but now I can see it can be any links we have: website, github, social media, marketplaces etc. so left it as it is right now